[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779262#action_12779262
]
Robert Muir commented on LUCENE-2037:
-------------------------------------
{quote}
I don't think it's worth trying to refactor that class into two classes, one
that has all the tests run with all the locales and one that has the rest of
the tests run only with the default locale (which is how I read the code in
LocalizedTestcase) for 10 seconds worth of time savings. One could emulate the
old process of excluding some tests by returning immediately from those tests
that weren't intended to be run with all locales if the current locale wasn't
the default, but I don't see that as worth the effort, although I could be
convinced otherwise if people feel strongly.
{quote}
Hi, the current behavior is a little silly.
I thought it would be user-friendly to run the default locale first, then all
the other locales (including a duplicate run of the default locale).
This way if you broke a test, you would see failures in your native
language/format rather than some very strange language.
On the other hand, by using LocalizedTestCase, you are saying 'hey i am saying
this thing has locale-sensitive behavior and it better work', so in my opinion,
getting rid of this 'first run tests under default locale' doesn't harm a thing.
instead, just run under all locales, or maybe sort them so the default one is
first, or something else?
> Allow Junit4 tests in our environment.
> --------------------------------------
>
> Key: LUCENE-2037
> URL: https://issues.apache.org/jira/browse/LUCENE-2037
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Environment: Development
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: junit-4.7.jar, LUCENE-2037.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> Now that we're dropping Java 1.4 compatibility for 3.0, we can incorporate
> Junit4 in testing. Junit3 and junit4 tests can coexist, so no tests should
> have to be rewritten. We should start this for the 3.1 release so we can get
> a clean 3.0 out smoothly.
> It's probably worthwhile to convert a small set of tests as an exemplar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
