[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779453#action_12779453
]
Robert Muir commented on LUCENE-2037:
-------------------------------------
{quote}
I was thinking more about TestQueryParser. One of the features of the
current setup is that you specify which tests in a class you want to have
run under all locales. Tests not in that list are run only under the default
locale.Always assuming I'm reading things right..
{quote}
Erick, oh I am sorry, I completely misread your comment!
This feature that allows only a subset of tests to be run "localized" where the
others will be run "normally" is just a performance optimization.
all tests should (have not checked since 2.9) pass under all locales.
{quote}
But I did notice last night that a number of tests in contrib reference
LocalizedTestCase (I have two separate projects, core and contrib so it
wasn't obvious until I ran the ant task). I'll look into those tonight or
tomorrow night.
{quote}
Yes, I do feel we should keep LocalizedTestCase. It is handy, we might use it
in more places to prevent test failures in other locales for new code.
But this "allowing only a subset of tests to be test in a localized way" is
only a performance optimization.
If there is some test class that is really slow because all the tests are run
under every locale, perhaps the locale-sensitive tests should be refactored
into a separate test class that extends LocalizedTestCase.
The ones that are not locale-sensitive could be in a test class that extends
LuceneTestCase
> Allow Junit4 tests in our environment.
> --------------------------------------
>
> Key: LUCENE-2037
> URL: https://issues.apache.org/jira/browse/LUCENE-2037
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Environment: Development
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: junit-4.7.jar, LUCENE-2037.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> Now that we're dropping Java 1.4 compatibility for 3.0, we can incorporate
> Junit4 in testing. Junit3 and junit4 tests can coexist, so no tests should
> have to be rewritten. We should start this for the 3.1 release so we can get
> a clean 3.0 out smoothly.
> It's probably worthwhile to convert a small set of tests as an exemplar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
