[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839181#action_12839181
]
Shai Erera edited comment on LUCENE-2285 at 2/27/10 7:22 AM:
-------------------------------------------------------------
Uwe, I've applied the patch and in Analyzers I see lots of compile errors due
to unrecognized Version.LUCENE_CURRENT (there is a missing import). I thought
that you let TEST_VERSION_CURRENT in, no? I changed all the contrib the tests
to extend from LuceneTestCase and use it. Perhaps you mistakenly left it out?
Actually all errors I see are related to Version unrecognized.
was (Author: shaie):
Uwe, I've applied the patch and in Analyzers I see lots of compile errors
due to unrecognized Version.LUCENE_CURRENT (there is a missing import). I
thought that you let TEST_VERSION_CURRENT in, no? I changed all the contrib the
tests to extend from LuceneTestCase and use it. Perhaps you mistakenly left it
out?
> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
> Key: LUCENE-2285
> URL: https://issues.apache.org/jira/browse/LUCENE-2285
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2285.patch, LUCENE-2285.patch, LUCENE-2285.patch
>
>
> I would like to do some code cleanup and remove all sorts of trivial
> warnings, like unnecessary casts, problems w/ javadocs, unused variables,
> redundant null checks, unnecessary semicolon etc. These are all very trivial
> and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like
> LuceneTestCase and all sorts of deprecated constructors. That's also trivial
> because it only affects Lucene code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the
> code, where it's missing today - not changing existing API. There are many
> places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then
> move on to the others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
