[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839211#action_12839211
]
Uwe Schindler commented on LUCENE-2285:
---------------------------------------
bq. Strange ... something's wrong w/ eclipse and how it read the patch file? I
tried to apply the patch which I created originally (and was on my computer,
not downloaded from JIRA) and it fails on the same files ... any ideas?
No, sorry. I don't use Eclipse at all, only for some refactoring.
I will commit the patch at the weekend and then update a second svn tree with
your old patch applied. "svn up" then makes it able to provide a patch with the
left out changes, we don't want to apply (some casts, sorry, and we won't fix
them). I just say it again: it compiles without any warnings using javac, we
cannot support stupiud warnings of other IDEs during our development, as
Eclipse is no official requirement. So I still strongy suggest to disable some
of the warnings already mentioned.
> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
> Key: LUCENE-2285
> URL: https://issues.apache.org/jira/browse/LUCENE-2285
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2285.patch, LUCENE-2285.patch, LUCENE-2285.patch
>
>
> I would like to do some code cleanup and remove all sorts of trivial
> warnings, like unnecessary casts, problems w/ javadocs, unused variables,
> redundant null checks, unnecessary semicolon etc. These are all very trivial
> and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like
> LuceneTestCase and all sorts of deprecated constructors. That's also trivial
> because it only affects Lucene code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the
> code, where it's missing today - not changing existing API. There are many
> places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then
> move on to the others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
