[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839187#action_12839187
]
Uwe Schindler edited comment on LUCENE-2285 at 2/27/10 8:08 AM:
----------------------------------------------------------------
Hi Shai,
I applied the patch to a fresh checkout and get no compile errors. Are you sure
that the patch applied correctly? I am working in Windows, so if you are not
using a patch-apply tool like TortoiseSVN that can accept windows line endings,
you have to maybe use dos2unix before?
And don't forget to update your package in Eclipse (press F5). I had this type
of errors very often because Eclipse caches the sources.
All tests pass here and no compile errors, also in demo webapp and so on (using
ANT).
was (Author: thetaphi):
Hi Shai,
I applied the patch to a fresh checkout and get no compile errors. Are you sure
that the patch applied correctly? I am working in Windows, so if you are not
using a patch-apply tool like TortoiseSVN that can accept windows line endings,
you have to maybe use dos2unix before?
All tests pass here and no compile errors, also in demo webapp and so on (using
ANT).
> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
> Key: LUCENE-2285
> URL: https://issues.apache.org/jira/browse/LUCENE-2285
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2285.patch, LUCENE-2285.patch, LUCENE-2285.patch
>
>
> I would like to do some code cleanup and remove all sorts of trivial
> warnings, like unnecessary casts, problems w/ javadocs, unused variables,
> redundant null checks, unnecessary semicolon etc. These are all very trivial
> and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like
> LuceneTestCase and all sorts of deprecated constructors. That's also trivial
> because it only affects Lucene code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the
> code, where it's missing today - not changing existing API. There are many
> places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then
> move on to the others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
