[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839259#action_12839259
]
Uwe Schindler commented on LUCENE-2285:
---------------------------------------
bq. UnicodeUtil
I reverted the whole class as it is very sensitive to binary encoding, so
please leave it as it is. Tell me any @SuppressWarnings parameter that makes
eclipse happy, I will add it!
bq. TestCharacterUtils
I missed that this test is junit4, in junit3 the casts are necessary. But if
you bug me longer with these casts I will give the issue to somebody else :-)
bq. AnalyzingQueyrParser
I simply reverted everything with QueryParser in it, because it is normally
generated code. :-) As I said before, let us first commit this patch. But i
will no longer discuss about casts :-)
Thanks for reviewing the patch, its a good help to get code cleaner!
> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
> Key: LUCENE-2285
> URL: https://issues.apache.org/jira/browse/LUCENE-2285
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2285.patch, LUCENE-2285.patch, LUCENE-2285.patch
>
>
> I would like to do some code cleanup and remove all sorts of trivial
> warnings, like unnecessary casts, problems w/ javadocs, unused variables,
> redundant null checks, unnecessary semicolon etc. These are all very trivial
> and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like
> LuceneTestCase and all sorts of deprecated constructors. That's also trivial
> because it only affects Lucene code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the
> code, where it's missing today - not changing existing API. There are many
> places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then
> move on to the others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
