On May 30, 2007, at 2:45 AM, Ryan McKinley wrote:

I'm trying to build a custom MoreLikeThis implementation that will run within solr and I've run into a few API hurdles...

1. Can MLT.java be modified to optionally take the Similarity implementation in the constructor? Currently it is hardcoded to:
 private Similarity similarity = new DefaultSimilarity();


Seems reasonable. I suppose accessors would be reasonable too, since many of the other attributes have accessors.


2. Do retrieveTerms(int docNum) and createQuery(PriorityQueue q) need to be private? Can they be public? If not public, could they at least be protected?


I would think protected would be fine, what is your case for it being public?

3. Can isNoiseWord() be protected?


Seems reasonable.


If these changes sound reasonable, I'll make a JIRA patch.

thanks
ryan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--------------------------
Grant Ingersoll
Center for Natural Language Processing
http://www.cnlp.org/tech/lucene.asp

Read the Lucene Java FAQ at http://wiki.apache.org/jakarta-lucene/ LuceneFAQ



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to