On Tue, 24 May 2022 16:39:25 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeScanner.java line
> 515:
>
>> 513: * {@inheritDoc}
>> 514: *
>> 515: * @param node {@inheritDoc}
>
> There's something wrong with the `@implSpec` tags in this and the immediately
> following two methods. Might be an artifact of the patch.
Believed fixed.
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
> line 1533:
>
>> 1531: public DCTree parse(int pos) throws ParseException {
>> 1532: skipWhitespace();
>> 1533: DCText url = inlineWord();
>
> Nit: call it `uri` for consistency.
Update, the terminology is converging on `URL` in all public places, with
`java.net.URI` being used as needed within the doclet implementation.
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
> line 432:
>
>> 430: doclet.extSpec.url.title=\
>> 431: url: {0}, title: "{1}"
>> 432:
>
> Use `uri` in all 4 resources?
Converging on URL.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8439
