On Tue, 24 May 2022 16:55:14 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java
>  line 1098:
> 
>> 1096: 
>> 1097:     /**
>> 1098:      * Argument for command-line option {@code --spec-base-URI}.
> 
> I think the option is lower-cased `--spec-base-uri`.

yes, and now `--spec-base-url`.

> test/langtools/tools/javac/diags/examples/NoTitle.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights 
>> reserved.
> 
> 2012? Is it an old file from the previous incarnation of the `@spec` tag?

>From the file it was derived from.   It's always a toss-up when cloning and 
>modifying an old file.  2012 removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8439

Reply via email to