On Fri, 2 Jun 2023 22:29:44 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8304135
>> - Extract getActualMethod
>> - Impose (almost) legacy order on implemented methods
>>
>> The legacy order is generated by an application of
>> Utils.overriddenMethod followed by application of
>> Utils.addSuperInterfaces.
>> - Fix errors reported by jcheck
>> - Initial commit
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java
> line 622:
>
>> 620: * given method.
>> 621: */
>> 622: public Optional<ExecutableElement>
>> getActualMethod(ExecutableElement method) {
>
> This doesn't feel like it belongs on `TagletWriterImpl`
I'm okay with making it private, but this functionality is only currently
needed in this class to replace code 50-ish lines above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14221#discussion_r1224028727
