On Fri, 2 Jun 2023 22:45:20 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8304135
>> - Extract getActualMethod
>> - Impose (almost) legacy order on implemented methods
>>
>> The legacy order is generated by an application of
>> Utils.overriddenMethod followed by application of
>> Utils.addSuperInterfaces.
>> - Fix errors reported by jcheck
>> - Initial commit
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java
> line 1001:
>
>> 999:
>> 1000: private com.sun.tools.javac.util.List<OverrideData>
>> findOverriddenBy(ExecutableElement m) {
>> 1001: return findOverriddenBy(m, (DeclaredType) te.asType(),
>> com.sun.tools.javac.util.List.nil(), new HashSet<>());
>
> What is pushing you into having to use `javac`'s internal `List` class?
IIRC, it's a combination of vestigial reasons and the fact that there's the
`reverse()` method, whose cousin SequencedCollection.reversed() is sadly
unavailable in langtools in JDK 21 because of "JDK N-1".
I'll try to get rid of javac's list here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14221#discussion_r1224059741
