On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung <[email protected]> wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by cstein (Committer).
German translations read OK.
Nit: some layouts get lost in translated files - it would be great to have
similar usage of `\n` and `` in the translated files.
For example, the English file
`src/java.base/share/classes/sun/launcher/resources/launcher.properties` has
good (easy to compare) layout:
java.launcher.opt.header = Usage: {0} [options] <mainclass> [args...]\n\
\ (to execute a class)\n\
\ or {0} [options] -jar <jarfile> [args...]\n\
\ (to execute a jar file)\n\
\ or {0} [options] -m <module>[/<mainclass>] [args...]\n\
\ {0} [options] --module <module>[/<mainclass>] [args...]\n\
\ (to execute the main class in a module)\n\
\ or {0} [options] <sourcefile> [args]\n\
\ (to execute a source-file program)\n\n\
[...]
The German translation in
`src/java.base/share/classes/sun/launcher/resources/launcher_de.properties`
uses only a single line in its properties file:
java.launcher.opt.header = Verwendung: {0} [Optionen] <Hauptklasse>
[args...]\n (zur Ausführung einer Klasse)\n oder {0} [Optionen]
-jar <JAR-Datei> [args...]\n (zur Ausführung einer JAR-Datei)\n
oder {0} [Optionen] -m <Modul>[/<Hauptklasse>] [args...]\n {0}
[Optionen] --module <Modul>[/<Hauptklasse>] [args...]\n (zur
Ausführung der Hauptklasse in einem Modul)\n oder {0} [Optionen]
<Quelldatei> [args]\n (zur Ausführung eines Programms mit einer
Quelldatei)\n\n[...]
Changes in the latter are not easy to spot and review.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1781603832
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1855667603