On Tue, 30 Apr 2024 10:52:23 GMT, psoujany <d...@openjdk.org> wrote:

>> The scrollable element `<div>` with non-interactive content is not tabbable. 
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing 
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove trailing whitespaces

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java
 line 339:

> 337:         for (Content c : contents) {
> 338:             HtmlStyle cellStyle = columnStyles.get(colIndex);
> 339:             // Add tab order to only plain text to avoid 
> widget_tabbable_single(potential violation)

`widget_tabbable_single` sounds like a programmatic name. Can we provide a 
better explanation of what this rule means, maybe also adding a link? [This 
piece of code][tabbable-single] seems to provide an explanation, but I'm not 
sure what it means in the current context.

[tabbable-single]: 
https://github.com/IBMa/equal-access/blob/7954dcdc5f1b5536057f783abcae1f7521265200/karma-accessibility-checker/test/client/baseline/JSONObjectStructureVerification.html.json#L2810-L2811

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1613622805

Reply via email to