On Fri, 24 May 2024 15:03:05 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> psoujany has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespaces
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java
> line 339:
>
>> 337: for (Content c : contents) {
>> 338: HtmlStyle cellStyle = columnStyles.get(colIndex);
>> 339: // Add tab order to only plain text to avoid
>> widget_tabbable_single(potential violation)
>
> `widget_tabbable_single` sounds like a programmatic name. Can we provide a
> better explanation of what this rule means, maybe also adding a link? [This
> piece of code][tabbable-single] seems to provide an explanation, but I'm not
> sure what it means in the current context.
>
> [tabbable-single]:
> https://github.com/IBMa/equal-access/blob/7954dcdc5f1b5536057f783abcae1f7521265200/karma-accessibility-checker/test/client/baseline/JSONObjectStructureVerification.html.json#L2810-L2811
@hns We're trying to add tab order only to plain elements here so that we can
avoid multiple tabbable elements in the tablist, as other elements like
link,object,buttons have default tab order. I modified comment as you
suggested. Could you please review once. Thank you.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1615851134
