On Mon, 17 Jun 2024 15:10:52 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete an extra whitespace
>
> test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line
> 58:
>
>> 56: if(Platform.isRoot() && !tester.isWindows()) {
>> 57: throw new SkippedException("root user has privileged will
>> make this test fail.");
>> 58: }
>
> Suggestion:
>
> if (Platform.isRoot() && !tester.isWindows()) {
> throw new SkippedException("root user has privileges that will
> make this test fail");
> }
> var tester = new TestIOException();
`isWindows()` is not static, so call this function need a instance
`TestIOException` object, thus `var tester = new TestIOException();` should at
before line 56.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1643003292
