On Sat, 15 Jun 2024 09:54:38 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> Test >> `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run >> fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > delete an extra whitespace test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line 56: > 54: public static void main(String... args) throws Exception { > 55: var tester = new TestIOException(); > 56: if(Platform.isRoot() && !tester.isWindows()) { Suggestion: if (Platform.isRoot() && !tester.isWindows()) { ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1643875959