On Mon, 17 Jun 2024 16:10:08 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

> ```
> -    private Error error(File f, String message) {
> +    private Error skip(File f, String message) {
> +        out.print(System.getProperty("user.name"));
>          out.println(f + ": " + message);
>          showAllAttributes(f.toPath());
>          throw new Error(f + ": " + message);
> @@ -242,20 +234,5 @@ private void showAttributes(Path p, String attributes) {
>              out.println("Error accessing attributes " + attributes + ": " + 
> t);
>          }
>      }
> ```

Does the `throw new Error(f + ": " + message);` should be replaced to `throw 
new SkippedException(f + ": " + message);`, to avoid report failure if a 
directory cannot be made read-only.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2174732914

Reply via email to