On Tue, 30 Jul 2024 22:45:03 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties > line 283: > >> 281: doclet.record_equals_doc.fullbody.tail.both=参照コンポーネントは{@link >> java.util.Objects#equals(Object,Object) >> Objects::equals(Object,Object)}と比較され、プリミティブ・コンポーネントは対応するラッパー・クラスの<code>compare</code>メソッドと比較されます。 >> 282: >> 283: >> doclet.record_equals_doc.fullbody.tail.primitive=このレコード・クラスのすべてのコンポーネントは対応するラッパー・クラスの<code>compare</code>メソッドと比較されます。 > > These translation are somewhat questionable. IIUC the original English > meaning is to compare components to each other *using* the `compare` methods > in the wrappers, but these Japanese translations imply compare components > *to* the `compare` methods in the wrappers. If you are able to provide a better translation, that would be ideal. We can replace this translation with that one, as well as filing a bug against the translation tool asking them to use yours. Otherwise, we should probably not revert this change, as while it is questionable, it is still updated to match the new English definition, and the previous localized definition would not match since it is outdated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20394#discussion_r1697686854