Jerry: This makes sense. I think you should add a comment to the spec-file to highlight why the patch is needed and why this is a branding patch. Otherwise, it is confusing.
I also think it would be good to report the issue upstream. If the patch doesn't break the behavior for other systems, then they might accept this upstream. It is worth a try, I think. Brian > This bug is complicated. > > it only reproduce on opensolaris with user who has primary admin role. > when run it using gksu, sound-juicer will start as root. > its dbus environment is set but it can not enter that dbus. > > it is related with the patch which applied to Gconf to unset dbus > environment variable. > see bug 555745 . > > Since the bug 555745 is still unconfirmed, the patch for it is still > local, > my patch is depended on it, so I mark it as branding patch. > > > And linux user does not have problem to run sound-juicer since user can > access CD without special permission, > they dont need to run it using gksu, > they may don't care my patch. > > >> >> Jerry: >> >> This is marked as a branding patch in the sound-juicer spec-file. >> However, it doesn't look like a branding patch, and the core dump >> in doo bug #9592 that this patch fixes does not seem like a branding >> issue. >> >> Shouldn't this be reported upstream, and the spec-file updated with >> the bugzilla.gnome.org bug number as well? >> >> Brian >> >> >>> Author: jerrytan >>> Repository: /svn/jds/spec-files >>> Latest revision: 18591 >>> Total changesets: 1 >>> Branch: branches/gnome-2-26 >>> Date: 2009-06-23 06:52:18 +0000 (Tue, 23 Jun 2009) >>> >>> Added files: >>> branches/gnome-2-26/patches/sound-juicer-03-gconf.diff >>> Modified files: >>> branches/gnome-2-26/ChangeLog >>> branches/gnome-2-26/base-specs/sound-juicer.spec >>> >>> Log message: >>> add patch to fix bug 9592 >>> >>> >>> ------------------------------------------------------------------------ >>> >>> U branches/gnome-2-26/ChangeLog >>> U branches/gnome-2-26/base-specs/sound-juicer.spec >>> A branches/gnome-2-26/patches/sound-juicer-03-gconf.diff >> > >
