Michael:

> Log message:
> 2008-03-08 Michal Pryc <Michal.Pryc at Sun.Com>
> 
>         * libggz-01-config.diff: Added. Fixes build problems without 
> encryption.

This patch meets our immediate needs of disabling encryption from
libggz.  However, this patch doesn't look like it is upstreamable.  I
notice that the libggz configure script supports these options:

   --with-gcrypt           Add encryption support
   --with-tls[=ARG]        GnuTLS or OpenSSL - auto if no ARG

Wouldn't it be better to just specify --without-tls and --without-gcrypt
on configure to disable these features?

I'd say if the configure script, for some reason doesn't support this,
that it would be better to fix the configure script to properly work
with the --with and --without options rather than hacking things like
LIBS and LDADD directly.

It would be better to fix this patch so we can get this upstream, I
think.

Brian

Reply via email to