Brian Cameron wrote: > > Michael: > >> Log message: >> 2008-03-08 Michal Pryc <Michal.Pryc at Sun.Com> >> >> * libggz-01-config.diff: Added. Fixes build problems without >> encryption. > > This patch meets our immediate needs of disabling encryption from > libggz. However, this patch doesn't look like it is upstreamable. I > notice that the libggz configure script supports these options: > > --with-gcrypt Add encryption support > --with-tls[=ARG] GnuTLS or OpenSSL - auto if no ARG > > Wouldn't it be better to just specify --without-tls and --without-gcrypt > on configure to disable these features? > > I'd say if the configure script, for some reason doesn't support this, > that it would be better to fix the configure script to properly work > with the --with and --without options rather than hacking things like > LIBS and LDADD directly. > > It would be better to fix this patch so we can get this upstream, I > think.
Brian, It is already upstream in the svn, but the tarball with 0.0.14.1 does not have those changes that is why I had made this patch. The problem was that configure scripts were broken so I couldn't use those flags to disable encryption. The patch allows to use --without-gcrypt --without-tls flags, otherwise they were simply not working and libggz was build with encryption regardless the flags were used or not. From svn log (libggz): ------------------------------------------------------------------------ r9779 | josef | 2008-03-07 17:09:08 +0000 (Fri, 07 Mar 2008) | 3 lines - use LIBS instead of LDADD, detected by migi ------------------------------------------------------------------------ r9776 | josef | 2008-03-06 18:35:58 +0000 (Thu, 06 Mar 2008) | 3 lines - use the correct autoconf variable so encryption can be disabled best Michal
