# date:2008-01-23 owner:jerrytan type:branding
Patch7: %{name}-07-firefox-history.diff
I call it as branding, because it only exists on solaris build, and
yes, it is called feature better.
for the man page diff, because we add a link to opensolaris web site.
I think we need this branding patch.
Laszlo (Laca) Peter wrote:
> Hi Halton,
>
> On Tue, 2008-02-26 at 12:02 +0800, Halton Huo wrote:
>
>>>> ln -s ../../firefox/extensions/\{fda00e13-8c62-4f63-9d19-d168115b11ca\}
>>>> \{fda00e13-8c62-4f63-9d19-d168115b11ca\}
>>>>
>>> Where is this magic number coming from?
>>> In any case, I suggest you use a macro or a variable to avoid typos.
>>>
>> Good idea, apply.
>>
>
> So where's this number coming from? (Just wondering)
>
>
>>> Okay, so the "extension" package includes ff and tb extensions
>>> for tracker? Hmm... I would prefer to have them in 2 separete
>>> pkgs: SUNWdesktop-search-firefox and SUNWdesktop-search-thunderbird,
>>> dependant upon SUNWfirefox and SUNWthunderbird respectively.
>>>
>> Accept, need I send the package name request to RE again?
>>
>
> Yes, RE will need to register the new package names.
>
>
>>>> %files root
>>>> %defattr (-, root, sys)
>>>> %dir %attr (0755, root, sys) %{_sysconfdir}
>>>> %{_sysconfdir}/*
>>>>
>>> I'm not sure what's in the root pkg (maybe the %files root section
>>> should be more explicit?) but SUNWdesktop-search should probably
>>> depend on it.
>>>
>> There are autostart .desktop files in. Change like below more
>> specifically,
>> %files root
>> %defattr (-, root, sys)
>> %dir %attr (0755, root, sys) %{_sysconfdir}
>> %dir %attr (0755, root, sys) %{_sysconfdir}/xdg
>> %dir %attr (0755, root, sys) %{_sysconfdir}/xdg/autostart
>> %{_sysconfdir}/xdg/autostart/*.desktop
>>
>> Need run postscript for this?
>>
>
> Looks better. No need for a postinstall script.
>
>
>>>> rpm spec file
>>>> attachment
>>>> (SUNWdesktop-search-libs.spec)
>>>>
>>>>
>>>
>>>> Requires: SUNWpostrun
>>>>
>>> Only the root pkg seems to use postrun so this shouldn't be
>>> needed.
>>>
>> Removed. Add Requires: SUNWdesktop-search-libs-root
>>
>
> I've just noticed, the -devel package should depend on the
> main package too (and probably many other -devel pkgs, e.g.
> SUNWgnome-base-libs-devel).
>
>
>>>> # date:2008-01-23 owner:halton type:bug
>>>> bugzilla:503725,503727,503960,503966,504000
>>>> Patch4: %{name}-04-tp-reindex.diff
>>>>
>>> I don't see this patch attached to any of these bug reports,
>>> are these bugids correct?
>>>
>
>
>> These bugs are on http://bugzilla.gnome.org
>>
>
> Yes, that's where I was looking, but didn't see this
> patch attached to any of these 5 bug report. There was
> a different patch attached by someone else to one of them.
> I guess my question is whether this patch was submitted
> upstream.
>
>
>>>> # date:2008-01-23 owner:jerrytan type:branding
>>>> Patch7: %{name}-07-firefox-history.diff
>>>>
>>> And neither does this. Are you guys pushing these upstream?
>>>
>> Will hold until tracker 0.7.x released. No schedule now, can we change
>> 06 and 07 to feature?
>>
>
> Yes, it's definitely a feature patch and not a branding patch.
>
> Thanks,
> Laca
>
>
