Laszlo (Laca) Peter wrote:
> On Tue, 2008-08-05 at 11:53 +0100, Padraig O'Briain wrote:
>
>   
>> %post
>> /usr/bin/install-info %{_datadir}/info/groff %{_datadir}/info/dir
>>
>> %preun
>> /usr/bin/install-info -delete %{_datadir}/info/groff
>> %{_datadir}/info/dir
>>     
>
> These are not Live Upgrade or Jumpstart compliant.  I suggest
> removing them.  There are plans for implementing an SMF service
> that automatically updates the info dir file.
>
>   
OK.
>> %files 
>>     
> (...)
>   
>> %{_datadir}/groff/*
>>     
>
>   
>> %if %build_l10n
>> %files l10n
>> %defattr (-, root, bin)
>> %dir %attr (0755, root, sys) %{_datadir}
>> #%attr (-, root, other) %{_datadir}/locale
>> %{_datadir}/groff/%version/*
>>     
>
> This is already included in %files, see above.  Are there any
> l10n files there?
>
>   
No.

I have removed these lines from the spec file.

>> %endif
>>     
>
>   
>> --- /usr/tmp/clean/groff-1.19.2/Makefile.in     2005-08-07
>> 09:03:33.000000000 +0100
>> +++ groff-1.19.2/Makefile.in    2008-07-04 08:54:17.578878000 +0100
>> @@ -233,11 +233,11 @@
>>  man1dir=$(manroot)/man$(man1ext)
>>  
>>  # `man5ext' is the man section for file formats.
>> -man5ext=5
>> +man5ext=4
>>  man5dir=$(manroot)/man$(man5ext)
>>  
>>  # `man7ext' is the man section for macros.
>> -man7ext=7
>> +man7ext=5
>>  man7dir=$(manroot)/man$(man7ext)
>>  
>>     
>
> You could just run make install with man5ext=4 man7ext=5 as arguments.
>   
Thanks. I have updated the spec file and removed the patch.
Updated spec file attached.

> Laca
>
>
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080806/5d425d48/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SUNWgroff.spec
Type: text/x-rpm-spec
Size: 2987 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080806/5d425d48/attachment.bin>

Reply via email to