[ 
https://issues.apache.org/jira/browse/JENA-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119947#comment-13119947
 ] 

Andy Seaborne commented on JENA-127:
------------------------------------

Andy;s commit on SF was a mistake due to bad Eclipse setup).

Rob - as this is a new functionality, the attached whole file or the patch look 
fine. It 's far more important that there are tests ... and there are.  Small 
differences in source code alignment are just a fact of distributed working and 
only become difficult when there are overlapping or related changes.  That's 
not true here - we'll cope!

                
> Add RDF/JSON Parsing Support to RIOT
> ------------------------------------
>
>                 Key: JENA-127
>                 URL: https://issues.apache.org/jira/browse/JENA-127
>             Project: Jena
>          Issue Type: New Feature
>          Components: Jena, RIOT
>         Environment: All
>            Reporter: Rob Vesse
>            Assignee: Paolo Castagna
>            Priority: Minor
>              Labels: patch, rdf/json, riot
>         Attachments: JenaReaderRdfJson.java, LangRDFJSON.java, 
> RdfJsonRiotPatch-ApacheSVN.patch, RdfJsonRiotPatch.patch, 
> RdfJsonRiotPatch.patch, TestLangRdfJson.java, TestLangRdfJson.java
>
>
> The attached patch provides a RDF/JSON (Talis Specification) parser for RIOT, 
> the patch is against ARQ trunk from the Jena SourceForge SVN repository
> It plugs in as an implementation of LangRIOT (named LangRDFJSON) and uses the 
> existing TokenizerJSON from the atlas package to do the tokenisation.  There 
> is also a JenaReaderRdfJson added as part of this patch which does what the 
> name suggests.
> I have also included in this patch a set of unit tests which verify the 
> parsers behaviour with a variety of valid and invalid inputs.
> There are still some things to be addressed:
> - The patch includes registration of the Jena reader when 
> SysRiot.writeIntoJena() is called but does not unregister itself when 
> resetJenaReaders() is called, should this be done?
> - Add a RDF/JSON writer - a separate patch will be submitted at a later date 
> (likely next week) for this
> Otherwise the patch is fairly comprehensive and I hope can be reviewed and 
> included in future releases
> EDIT - I have now redone the patch against Apache SVN as well and attached 
> that as a separate file since there are some differences in the structure of 
> the two repos and some minor code changes that mean the SourceForge SVN patch 
> cannot be applied directly against Apache SVN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to