[ 
https://issues.apache.org/jira/browse/JENA-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121947#comment-13121947
 ] 

Rob Vesse commented on JENA-127:
--------------------------------

I generated it with Tortoise SVN by doing Tortoise SVN > Create Patch

Just tried doing svn diff and for some reason it still incorporates the 
complete files for no apparent reason, if you look at the patch against SF SVN 
you'll see it only incorporates the changed lines so not sure what's going on 
there.  I did the Apache SVN patch by looking at my SF SVN patch and just 
copying and pasting the relevant changes across.  All the incoporated files 
have some changes to them

Only difference between how I created the two patches was that the Apache SVN 
one was done with a simple text editor while the SF SVN one was done with 
Eclipse so possibly the simple editor borked all the whitespace in the files 
hence why it thinks the entire files have changed
                
> Add RDF/JSON Parsing Support to RIOT
> ------------------------------------
>
>                 Key: JENA-127
>                 URL: https://issues.apache.org/jira/browse/JENA-127
>             Project: Jena
>          Issue Type: New Feature
>          Components: Jena, RIOT
>         Environment: All
>            Reporter: Rob Vesse
>            Assignee: Paolo Castagna
>            Priority: Minor
>              Labels: patch, rdf/json, riot
>         Attachments: JenaReaderRdfJson.java, LangRDFJSON.java, 
> RdfJsonRiotPatch-ApacheSVN.patch, RdfJsonRiotPatch.patch, 
> RdfJsonRiotPatch.patch, TestLangRdfJson.java, TestLangRdfJson.java
>
>
> The attached patch provides a RDF/JSON (Talis Specification) parser for RIOT, 
> the patch is against ARQ trunk from the Jena SourceForge SVN repository
> It plugs in as an implementation of LangRIOT (named LangRDFJSON) and uses the 
> existing TokenizerJSON from the atlas package to do the tokenisation.  There 
> is also a JenaReaderRdfJson added as part of this patch which does what the 
> name suggests.
> I have also included in this patch a set of unit tests which verify the 
> parsers behaviour with a variety of valid and invalid inputs.
> There are still some things to be addressed:
> - The patch includes registration of the Jena reader when 
> SysRiot.writeIntoJena() is called but does not unregister itself when 
> resetJenaReaders() is called, should this be done?
> - Add a RDF/JSON writer - a separate patch will be submitted at a later date 
> (likely next week) for this
> Otherwise the patch is fairly comprehensive and I hope can be reviewed and 
> included in future releases
> EDIT - I have now redone the patch against Apache SVN as well and attached 
> that as a separate file since there are some differences in the structure of 
> the two repos and some minor code changes that mean the SourceForge SVN patch 
> cannot be applied directly against Apache SVN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to