Thanks for this post.
I think your bottom line is basically that you've created
https://gerrithub.io/ and you think we should be using it.
I hear a lot of good things about Gerrit, so I think this would be
interesting, especially if there's some interest among plugin developers.
Maybe we could schedule an office hour for this? So that interested
folks can ask you how this would benefit us. I for one don't quite
understand how this really works?
(For my uninitiated eyes, I must admit that I'm unclear how this fits
with our workflow in this project. I feel like pull requests are
providing good enough review mechanism when someone wants his code
reviewed, and if anything our problem is that we don't have enough
people to review code --- I want people to just go ahead and commit
their changes, instead of throwing the stuff over the wall and wait for
us to come around via pull requests.
What I really needed was to be able to just push changes and let Jenkins
test it *before* commits land to the repository, which we have already
solved via the validated merge in
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/)
On 10/10/2013 02:41 AM, Luca Milanesio wrote:
Hi Jenkins developers :-)
I am following up to a couple of discussion threads (one at
http://jenkins-ci.361315.n4.nabble.com/Jenkins-GitHub-and-Gerrit-Your-thoughts-td4630207.html
and another face-to-face with Kohsuke @Google Mountain View in 2011
http://google-opensource.blogspot.co.uk/2011/12/gittogether-2011.html)
about using GitHub or Gerrit for Jenkins development.
*We are all happily using GitHub pull requests* *BUT* there are _several
concerns on the web_, some of them coming directly from Linus Torvalds
on the lack of policy and order around GitHub pull requests:
http://www.wired.com/wiredenterprise/2012/05/torvalds_github/
Additionally *GitHub has been quite unreliable recently*, forcing (at
least us) to stop or slow down our activity quite often !
(just look on how many hints you have by Googling "github outage":
https://www.google.com/?q=github+outage)
Let me recap on the concerns of using Gerrit when we discussed with
Kohsuke F2F back in 2011 @GitTogether in Mountain View:
_1) Lack of GitHub synchronisation_
- Gerrit and GitHub are not very well synchronised in terms of
replication: you may end up with a situation where a push is made on
both Gerrit and GitHub and then you're stuck with a stale replication
conflict
_2) Not "as easy" as GitHub pull requests_
- Gerrit is GWT-based and its UX is not as nice and effective as GitHub
- More difficult to on-board new members because of the learning curve
involved with Gerrit
_3) Lack of visibility compared to GitHub_
- Gerrit has no public "Hub site" where people can go and look for
public repositories
_4) Lack of RESTFul API_
- Gerrit has no well-defined and stable RESTFul API as GitHub: more
difficult to integrate with other systems
Now, *_situation in October 2013 is VERY different,_* thanks to:
- Gerrit 2.8
(https://gerrit.googlesource.com/gerrit/+/refs/heads/master/ReleaseNotes/ReleaseNotes-2.8.txt)
- GitHub plugin for Gerrit
(https://gerrit.googlesource.com/plugins/github/+/refs/heads/master/README.md)
- The first book on Gerrit Code Review
(http://aniszczyk.org/2013/09/23/gerrit-code-review-book/)
- The first official Gerrit "Hub" for public projects (http://gerrithub.io)
*With all of those new aspects in mind: do we want to assess / review
the situation ?*
Those new elements are "filling the gaps" of the Gerrit minuses
identified 2 years ago:
1) GitHub plugin allows synchronisation of projects and pull requests
between GitHub and Gerrit (see a demo of Jenkins pull requests in Gerrit
on https://review.gerrithub.io)
2) Gerrit UX is getting much easier: the book shows how to get started
with Gerrit with minimal or no knowledge on Git
3) GerritHub.io is getting traction and allows to use Gerrit and GitHub
pull requests side-by-side
4) Gerrit 2.8 has a rich and powerful set of RESTFul API
(https://review.gerrithub.io/Documentation/rest-api.html)
Other _"big names" in OpenSource are already using Gerrit *AND* GitHub_
in conjunction with lots of success and pride:
- OpenStack (https://wiki.openstack.org/wiki/Gerrit_Workflow)
- Wikimedia (http://www.mediawiki.org/wiki/Gerrit)
- Typo3 (http://wiki.typo3.org/Gerrit)
Opinions, comments, plus and minuses are more than welcome :-)
Luca.
--
You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Jenkins Enterprise, our professional version of Jenkins
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
