I've taken now https://github.com/jenkinsci/pipeline-utility-steps-plugin
as an example of simple utility steps and will add a brand-new
implementation in Java.
On Thursday, January 4, 2018 at 7:57:15 AM UTC, lucamilanesio wrote:
>
> Good point: let me try to see what's the effort for the declarative
> pipeline compatibility :-)
>
> Luca.
>
> > On 3 Jan 2018, at 18:16, Jesse Glick <jgl...@cloudbees.com> wrote:
> >
> > On Wed, Jan 3, 2018 at 10:22 AM, Luca Milanesio
> > <luca.milane...@gmail.com> wrote:
> >> If you want to submit feedback to Gerrit in your pipeline, just add the
> following statement in your pipeline script:
> >>
> >> gerrit.review("Verified", 1, "It works !")
> >
> > I would urge you to use a plain old `Step` (no `workflow-cps`
> > dependency except in `test` scope, no `GerritDSL` + `Gerrit.groovy`),
> > e.g.:
> >
> > gerritReview status: 'Verified', vote: 1, message: 'It works!'
> >
> > You get a simpler implementation, *Pipeline Syntax* support,
> > compatibility with Declarative Pipeline, and the chance to work
> > unmodified with possible future execution engines.
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3DWgR4sZktwYLB_wuynLL8TURTMF-6F_f2wkUhTBoXBA%40mail.gmail.com.
>
>
> > For more options, visit https://groups.google.com/d/optout.
>
>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/a64a7487-d79a-4c25-aeff-e96645c4cfef%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
