First let me thank Luca for his work on this plugin. I started to test it, raised few bugs and also working on implementing full JJB support for it.
Regarding contributions, I think that it would be the best to follow Jenkins CI workflow (github with PR) here and avoid gerrit one. I see two important reasons: all jenkins plugins use the same process, diverging from standard is not good. Second, the plugin is too new to be considered stable, better to use a common/tested/stable process and focus on improving the plugin. Moving the repo under jenkinsci and enabling Jenkins ci testing would be the next natural step but there is no pressure. Now I only hope that I will see more activity on the issue tracker and as PRs being raised. I am eager to see it as reaching a stable release and I am sure that there are lots of people that could help with that. -- sorin > On 3 Jan 2018, at 18:16, Jesse Glick <[email protected]> wrote: > > On Wed, Jan 3, 2018 at 10:22 AM, Luca Milanesio > <[email protected]> wrote: >> If you want to submit feedback to Gerrit in your pipeline, just add the >> following statement in your pipeline script: >> >> gerrit.review("Verified", 1, "It works !") > > I would urge you to use a plain old `Step` (no `workflow-cps` > dependency except in `test` scope, no `GerritDSL` + `Gerrit.groovy`), > e.g.: > > gerritReview status: 'Verified', vote: 1, message: 'It works!' > > You get a simpler implementation, *Pipeline Syntax* support, > compatibility with Declarative Pipeline, and the chance to work > unmodified with possible future execution engines. > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/E3pvb0WH4Ls/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3DWgR4sZktwYLB_wuynLL8TURTMF-6F_f2wkUhTBoXBA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/E4C7F294-9200-4C1A-95BF-906A99154640%40gmail.com. For more options, visit https://groups.google.com/d/optout.
