> On 19 Jan 2018, at 10:29, Sorin Sbarnea <sorin.sbar...@gmail.com> wrote: > > First let me thank Luca for his work on this plugin. I started to test it, > raised few bugs and also working on implementing full JJB support for it.
Thanks for trying it out :-) I always appreciated early feedback. It is still a pre-alpha, so it is not suitable yet for production ... I am using it anyway on a daily basis and it works for me. However, still needs a lot of improvements. > > Regarding contributions, I think that it would be the best to follow Jenkins > CI workflow (github with PR) here and avoid gerrit one. I believe in dogfooding and innovation, rather than "standards". However, I see your point. It will stay on GitHub and reviews will be welcome from both GerritHub and GitHub sides :-) > > I see two important reasons: all jenkins plugins use the same process, > diverging from standard is not good. Why? The audience is "people that work with Jenkins and Gerrit" and I'd leave it to them to decide the best tool to do reviews. > Second, the plugin is too new to be considered stable, It isn't a stable release but rather a pre-alpha. > better to use a common/tested/stable process and focus on improving the > plugin. Gerrit Code Review and GitHub are both common, tested and stable processed IMHO. They have been around for ~ 10 years now. GerritHub.io <http://gerrithub.io/> was launched in 2013, 5 years ago, has 99.99% uptime and over 25k active users. > > Moving the repo under jenkinsci and enabling Jenkins ci testing would be the > next natural step but there is no pressure. See: https://github.com/jenkinsci/gerrit-plugin <https://github.com/jenkinsci/gerrit-plugin> > > Now I only hope that I will see more activity on the issue tracker and as PRs > being raised. I am eager to see it as reaching a stable release and I am sure > that there are lots of people that could help with that. I would have to close them and re-open them on the JenkinsCI project: the GerritForge one was just the pre-alpha inception. > > -- sorin > >> On 3 Jan 2018, at 18:16, Jesse Glick <jgl...@cloudbees.com >> <mailto:jgl...@cloudbees.com>> wrote: >> >> On Wed, Jan 3, 2018 at 10:22 AM, Luca Milanesio >> <luca.milane...@gmail.com> wrote: >>> If you want to submit feedback to Gerrit in your pipeline, just add the >>> following statement in your pipeline script: >>> >>> gerrit.review("Verified", 1, "It works !") >> >> I would urge you to use a plain old `Step` (no `workflow-cps` >> dependency except in `test` scope, no `GerritDSL` + `Gerrit.groovy`), >> e.g.: >> >> gerritReview status: 'Verified', vote: 1, message: 'It works!' >> >> You get a simpler implementation, *Pipeline Syntax* support, >> compatibility with Declarative Pipeline, and the chance to work >> unmodified with possible future execution engines. >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/E3pvb0WH4Ls/unsubscribe >> <https://groups.google.com/d/topic/jenkinsci-dev/E3pvb0WH4Ls/unsubscribe>. >> To unsubscribe from this group and all its topics, send an email to >> jenkinsci-dev+unsubscr...@googlegroups.com >> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3DWgR4sZktwYLB_wuynLL8TURTMF-6F_f2wkUhTBoXBA%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3DWgR4sZktwYLB_wuynLL8TURTMF-6F_f2wkUhTBoXBA%40mail.gmail.com>. >> For more options, visit https://groups.google.com/d/optout >> <https://groups.google.com/d/optout>. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com > <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/E4C7F294-9200-4C1A-95BF-906A99154640%40gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/E4C7F294-9200-4C1A-95BF-906A99154640%40gmail.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/242856C9-4C87-4481-9E7C-7579208D3553%40gmail.com. For more options, visit https://groups.google.com/d/optout.
