Thanks for the clarification! If there is no demand to get it released tomorrow, we are on the same page. Let's try to facilitate reviews, especially from the security team. Unfortunately I cannot commit my own time. Due to my current work assignments and personal commitments, I will have no time for reviewing big changes in the upcoming months.
> And there is a jQuery change coming? Yes, but not in 2.264. As requested by Felix, it is on hold until 2.266/267 https://github.com/jenkinsci/jenkins/pull/4929#issuecomment-715904763 On Mon, Oct 26, 2020 at 8:59 PM Jesse Glick <jgl...@cloudbees.com> wrote: > On Mon, Oct 26, 2020 at 3:52 PM Oleg Nenashev <o.v.nenas...@gmail.com> > wrote: > > I would vote for getting more reviews from the Jenkins Security Team > members before it gets merged. > > Oh agreed! > > > I am -0.5 regarding expediting this pull request. > > Neither needs to be expedited indeed. I would just not want to be > waiting weeks here (unless of course a concrete problem comes up that > forces more work). > > > XStream also includes a security risk due to class deserialization. > > Yes this aspect needs to be considered during review. (Existing tests > in that area pass, and the change _should_ not be modifying JEP-200 > behavior.) > > > We are already upgrading Winstone and changing tabs to divs in 2.264 > > And there is a jQuery change coming? (#4929) > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/ESpL69Paeg8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1ycaO5q9OiZ%3Dmt_c5wFGiVbdfnuZe0grV_%3Dv624sOXew%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCA8zW29PHDqkoTpGJ1H-XQ_K6MvRXwz%2BkV9xb8MyziYw%40mail.gmail.com.
