I don't remember seeing formal docs about it, but I believe it was changed for two reasons:
1. Dependency simplifications in general. That's been an ongoing effort by multiple people, particularly in Jenkins Core. 2. ASM needs to be upgraded more often now that Java itself is released more often. Even if you shade in ASM, you trade one problem for another in that newer Java releases are unable to run Jenkins (I'd give a pass for Java 16 since they changed some stuff related to poking at internals). I do think a JEP could be useful if it helped figure out a strategy for packaging and updating ASM to avoid compatibility issues for both ASM itself and Java. On Thu, 10 Jun 2021 at 03:46, jn...@cloudbees.com <jn...@cloudbees.com> wrote: > > Hi all, > > I have just noticed a few PRs (some merged) to change ASM in core or > libraries that core depdns on (stapler). > > I think we need to revert these and have a bigger think about ASM. > > ASM historically (and I believe still true) evolved in a non compatible way. > > In the past I have seen that versions add support for new class opcodes, but > this requires the code to implement the new methods to handle them as a > no-op, or causes linkage failures depending on how you use ASM. > > We also have a complete mix of ASM versions required for Core. (stapler / > BCT) can be aligned quite easily - but Guice also depends on ASM (our current > version of guice uses 5.0.3 (unshaded!)) and whilst newer versions of Guice > use 9, bumping to that may entail bumping Guava (which Guice also heavily > relies upon) and we are working towards that byut are not yet ready for it. > > I have not seen the ASM changes discussed before (sorry if I missed it). > Could we at least have a discussion here or via a JEP as I believe there are > several moving parts that need to align (and possible several things we > currently do that are also broken!). > > Thanks > > /James > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/8558ef90-cf4b-4edb-8c25-a33ab74c5f6bn%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CACmp6kr7qKzDLpViy3hbOiDE3tqa3AiN-YsS0rygwEq%2BUU5D5A%40mail.gmail.com.
