Hi Alan,
I had a look at the jdeps changes and they look good.
I have a couple of minor comments:
http://cr.openjdk.java.net/~alanb/8142968/2/langtools/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Archive.java.frames.html
120 @Override
121 public int hashCode() {
122 int hash = 7;
123 hash = 67*hash + Objects.hashCode(this.filename) +
124 Objects.hashCode(this.path);
125 return hash;
126 }
I wonder if that could be simplified in:
return Objects.hash(this.filename, this.path);
http://cr.openjdk.java.net/~alanb/8142968/2/langtools/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java.frames.html
typo:
443 // otherwise analyze the depednencies
best regards,
-- daniel
On 11/03/16 10:39, Alan Bateman wrote:
I've refreshed the webrevs here:
http://cr.openjdk.java.net/~alanb/8142968/2
so that we have a snapshot of what is currently in the jigsaw/jake
forest. The webrevs are against jdk-9+109.
As I said in the last mail, we would like to integrate this snapshot
into JDK 9 before the end of March. The proposal is to aim to integrate
during the week of March 21, with the the week of March 28 as fallback
in event of problems.
The related JEPs (JEP 200, JEP 260, JEP 261 and JEP 282) are now in
"Proposed to Target" state. Mark send mail to jdk9-dev with this list
and other proposals yesterday.
-Alan
