On 03/15/2016 02:22 PM, Alan Bateman wrote: [...]
Yuri needs to look at test/java/awt/xembed/server/TesterClient.java as that addExports usage is not right. I hope Yuri can also help on your
^ this one is historic: it is from immemorial July while the Helper class is dated by December. I could piggyback a change to the new version of my test fix currently on review.
comment about why skipTestingEmbeddedFrame=true is commented out in test/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java.
Originally, the tests run twice (second time with EmbeddedFrame) and reported "do not skipTestingEmbeddedFrame" in between. Then the Mac port work started, and that second run was skipped for Mac. Then unskipped.
test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh could do with a clean-up too, I assume the @compile was dropped because the test is invoking javac directly now.
Exactly; it requires now a different set of compile-time flags for every platform which is hard to pass in @compile. I decided not to remove it as a sign "avoid this" for a future reader. But then, what should I clean there? A commented out part? I could also append a change to the outstanding fix. -yan
