dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r893148152
########## clients/src/main/resources/common/message/AlterPartitionRequest.json: ########## @@ -18,16 +18,21 @@ "type": "request", "listeners": ["zkBroker", "controller"], "name": "AlterPartitionRequest", - "validVersions": "0-1", + // Version 1 adds LeaderRecoveryState field (KIP-704). + // + // Version 2 adds TopicId field to replace TopicName field (KIP-841). + "validVersions": "0-2", Review Comment: > if topic id is enabled (IBP 2.8) is it guarantee that every topic will have an id No, it is not. The broker could run with IBP 2.8 but have not topic ids yet because the controller does not use IBP 2.8 yet. In the end, we can use version 2 only if all the pending changes have a topic id. We have to use version 1 otherwise. Let me add a comment about this where we build the request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
