dajac commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r893199843
##########
core/src/main/scala/kafka/server/MetadataCache.scala:
##########
@@ -58,6 +58,10 @@ trait MetadataCache {
def hasAliveBroker(brokerId: Int): Boolean
+ def isBrokerFenced(brokerId: Int): Boolean
+
+ def isBrokerInControlledShutdown(brokerId: Int): Boolean
Review Comment:
I am not sure that I see the benefits. If we remove those methods, we need
to add another one which returns `BrokerRegistration` for a given broker. We
would need it in `Partition.isBrokerIsrEligible`. Or did I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
