dajac commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r893197172
##########
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##########
@@ -262,29 +291,35 @@ class DefaultAlterPartitionManager(
// Collect partition-level responses to pass to the callbacks
val partitionResponses = new mutable.HashMap[TopicPartition,
Either[Errors, LeaderAndIsr]]()
Review Comment:
Using `TopicIdPartition` here makes sense. However, we still need
`topicNamesByIds ` to get the name in order to construct `TopicIdPartition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
