[GitHub] [kafka] jolshan commented on a diff in pull request #12487: KAFKA-14140: Ensure an offline or in-controlled-shutdown replica is not eligible to join ISR in ZK mode

[GitBox]

jolshan commented on code in PR #12487:
URL: https://github.com/apache/kafka/pull/12487#discussion_r941537699


##########
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##########
@@ -1045,6 +1049,78 @@ class ControllerIntegrationTest extends 
QuorumTestHarness {
     assertEquals(expectedAlterPartitionResponse, future.get(10, 
TimeUnit.SECONDS))
   }
 
+  @ParameterizedTest
+  @MethodSource(Array("testAlterPartitionVersionSource"))

Review Comment:
   thanks! I was trying to remember how to do this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org