jolshan commented on code in PR #12487: URL: https://github.com/apache/kafka/pull/12487#discussion_r941543760
########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -881,11 +881,14 @@ class Partition(val topicPartition: TopicPartition, private def isReplicaIsrEligible(followerReplicaId: Int): Boolean = { metadataCache match { // In KRaft mode, only replicas which are not fenced nor in controlled shutdown are - // allowed to join the ISR. This does not apply to ZK mode. + // allowed to join the ISR. In ZK mode, we just ensure the broker is alive and not shutting down. Review Comment: Ok makes sense. Should I change the comment to reflect that this will not block shutting down brokers here, but will be blocked controller side? I think for at least this PR (which we want to get into 3.3) we should hold off on protocol changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org