showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1015096016
########## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java: ########## @@ -102,20 +104,26 @@ final class Subscription { private final ByteBuffer userData; private final List<TopicPartition> ownedPartitions; private Optional<String> groupInstanceId; + private final int generationId; Review Comment: Agree. Change to `Optional` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org