showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017394471
##########
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##########
@@ -78,6 +80,26 @@ public void testDecodeGeneration() {
assertFalse(((CooperativeStickyAssignor)
assignor).memberData(subscription).generation.isPresent());
}
+ @Test
Review Comment:
I agree we should add tests for the latest mechanism, but I think we should
still keep the tests for old schema. These are unit tests, which will not take
too long. I added variable to test old and new schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
