dajac commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017743686
##########
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##########
@@ -78,6 +80,26 @@ public void testDecodeGeneration() {
assertFalse(((CooperativeStickyAssignor)
assignor).memberData(subscription).generation.isPresent());
}
+ @Test
Review Comment:
I am not entirely convinced by adding version to all tests because it makes
the tests harder to read. I would rather used the most up to date scheme in the
tests and add new unit test for the backward compatibility. This seems more
explicit and would keep existing test simpler to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
