gharris1727 commented on code in PR #13185:
URL: https://github.com/apache/kafka/pull/13185#discussion_r1122467555
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -243,7 +248,11 @@ public synchronized void requestTaskReconfiguration(String
connName) {
log.error("Task that requested reconfiguration does not exist:
{}", connName);
return;
}
- updateConnectorTasks(connName);
+ try {
+ updateConnectorTasks(connName);
+ } catch (Exception e) {
+ log.error("Unable to generate task configs for {}", connName, e);
+ }
Review Comment:
Yes this is a change in behavior.
There is precedent for throwing ConnectException from
ConnectorContext::requestTaskReconfiguration, so perhaps wrapping this in a
ConnectException and propagating it would be a better behavior. I can move this
to HerderConnectorContext, except it would only be effective for the standalone
herder.
We can also see this as an opportunity to improve the StandaloneHerder by
handling reconfigurations asynchronously and retry them in the background,
rather than 500'ing the REST API or dropping the failure silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
