gharris1727 commented on code in PR #13185:
URL: https://github.com/apache/kafka/pull/13185#discussion_r1122473180
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -243,7 +248,11 @@ public synchronized void requestTaskReconfiguration(String
connName) {
log.error("Task that requested reconfiguration does not exist:
{}", connName);
return;
}
- updateConnectorTasks(connName);
+ try {
+ updateConnectorTasks(connName);
+ } catch (Exception e) {
+ log.error("Unable to generate task configs for {}", connName, e);
+ }
Review Comment:
Perhaps we can also consider this a failure of the signature of
Herder::requestTaskReconfiguration. The DistributedHerder makes this
asynchronous, but provides no future or callback to confirm the progress of the
request.
Arguably StandaloneHerder is implementing the function signature correctly
as a request that either succeeds or fails.
It also makes me think that a connector which repeatedly calls
requestTaskReconfiguration (and then always fails in generateTaskConfigs) could
spam the herder with retried restart requests. This is such a messy situation
that the old function signatures hid from us :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
