C0urante commented on code in PR #13185:
URL: https://github.com/apache/kafka/pull/13185#discussion_r1120754565
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -243,7 +248,11 @@ public synchronized void requestTaskReconfiguration(String
connName) {
log.error("Task that requested reconfiguration does not exist:
{}", connName);
return;
}
- updateConnectorTasks(connName);
+ try {
+ updateConnectorTasks(connName);
+ } catch (Exception e) {
+ log.error("Unable to generate task configs for {}", connName, e);
+ }
Review Comment:
This is a change in behavior too, right? We no longer throw in
`ConnectorContext::requestTaskReconfiguration` if we encounter any errors.
This also seems reasonable (it aligns the behavior across standalone and
distributed modes), but it does has consequences for the REST API, where
restarting a connector no longer fails if we're unable to generate task configs
for it (which is currently the case for both distributed and standalone modes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
