vcrfxia commented on code in PR #13292: URL: https://github.com/apache/kafka/pull/13292#discussion_r1127273827
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ########## @@ -1293,12 +1306,16 @@ private void setRegexMatchedTopicToStateStore() { private <S extends StateStore> InternalTopicConfig createChangelogTopicConfig(final StateStoreFactory<S> factory, final String name) { - if (factory.isWindowStore()) { + if (factory.isVersionedStore()) { + final VersionedChangelogTopicConfig config = new VersionedChangelogTopicConfig(name, factory.logConfig()); + config.setMinCompactionLagMs(factory.historyRetention()); Review Comment: > Why are we setting this "outside" but not via the constructor? (I see that we do the same thing for WindowedChangelogTopicConfig but I am not sure why either.) No reason, AFAICT -- I was just following precedent. Would you prefer passing `factory.historyRetention()` into the constructor and setting it there? I can refactor `WindowedChangelogTopicConfig` as well if so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org