vcrfxia commented on code in PR #13292:
URL: https://github.com/apache/kafka/pull/13292#discussion_r1127274296
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -1293,12 +1306,16 @@ private void setRegexMatchedTopicToStateStore() {
private <S extends StateStore> InternalTopicConfig
createChangelogTopicConfig(final StateStoreFactory<S> factory,
final String name) {
- if (factory.isWindowStore()) {
+ if (factory.isVersionedStore()) {
+ final VersionedChangelogTopicConfig config = new
VersionedChangelogTopicConfig(name, factory.logConfig());
+ config.setMinCompactionLagMs(factory.historyRetention());
Review Comment:
> Do we also need to increase `delete.retention.ms` for this case?
Nope, the changelog topic for verisoned stores is only compacted, so
`delete.retention.ms` is unused. (In contrast to the windowed changelog topic
case, where both compaction and retention-based deletion are enabled)
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -1293,12 +1306,16 @@ private void setRegexMatchedTopicToStateStore() {
private <S extends StateStore> InternalTopicConfig
createChangelogTopicConfig(final StateStoreFactory<S> factory,
final String name) {
- if (factory.isWindowStore()) {
+ if (factory.isVersionedStore()) {
+ final VersionedChangelogTopicConfig config = new
VersionedChangelogTopicConfig(name, factory.logConfig());
+ config.setMinCompactionLagMs(factory.historyRetention());
Review Comment:
> Do we also need to increase `delete.retention.ms` for this case?
Nope, the changelog topic for versioned stores is only compacted, so
`delete.retention.ms` is unused. (In contrast to the windowed changelog topic
case, where both compaction and retention-based deletion are enabled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
