mjsax commented on code in PR #13292: URL: https://github.com/apache/kafka/pull/13292#discussion_r1142842326
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ########## @@ -1293,12 +1306,16 @@ private void setRegexMatchedTopicToStateStore() { private <S extends StateStore> InternalTopicConfig createChangelogTopicConfig(final StateStoreFactory<S> factory, final String name) { - if (factory.isWindowStore()) { + if (factory.isVersionedStore()) { + final VersionedChangelogTopicConfig config = new VersionedChangelogTopicConfig(name, factory.logConfig()); + config.setMinCompactionLagMs(factory.historyRetention()); Review Comment: > It's not strictly necessary though. If not necessary, no need to do anything. Just wanted to probe if we need to do anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org