rondagostino commented on code in PR #13337:
URL: https://github.com/apache/kafka/pull/13337#discussion_r1125021084
##########
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##########
@@ -31,10 +32,16 @@ class DynamicConfigPublisher(
faultHandler: FaultHandler,
dynamicConfigHandlers: Map[String, ConfigHandler],
nodeType: String
-) extends Logging {
+) extends org.apache.kafka.image.publisher.MetadataPublisher with Logging {
logIdent = s"[DynamicConfigPublisher nodeType=${nodeType} id=${conf.nodeId}]
"
- def publish(delta: MetadataDelta, newImage: MetadataImage): Unit = {
+ def name(): String = "DynamicConfigPublisher"
+
+ def publish(
+ delta: MetadataDelta,
+ newImage: MetadataImage,
+ manifest: LoaderManifest
Review Comment:
`Option[LoaderManifest]` since it is optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
