cmccabe commented on code in PR #13337:
URL: https://github.com/apache/kafka/pull/13337#discussion_r1131705968
##########
metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotGenerator.java:
##########
@@ -200,7 +201,24 @@ void resetSnapshotCounters() {
}
@Override
- public void publishSnapshot(
+ public void onMetadataUpdate(
+ MetadataDelta delta,
+ MetadataImage newImage,
+ LoaderManifest manifest
+ ) {
+ switch (manifest.type()) {
+ case LOG_DELTA:
+ publishLogDelta(delta, newImage, (LogDeltaManifest) manifest);
+ break;
+ case SNAPSHOT:
+ publishSnapshot(delta, newImage, (SnapshotManifest) manifest);
+ break;
+ default:
+ break;
Review Comment:
Actually, let's just remove the `default` case. spotbugs will flag
non-exhaustive switch statements on enums. And that's a hard build error for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
