rondagostino commented on code in PR #13337:
URL: https://github.com/apache/kafka/pull/13337#discussion_r1131578840
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##########
@@ -213,32 +212,13 @@ class BrokerMetadataPublisher(
}
// Apply configuration deltas.
- dynamicConfigPublisher.publish(delta, newImage)
+ dynamicConfigPublisher.onMetadataUpdate(delta, newImage)
// Apply client quotas delta.
- try {
- Option(delta.clientQuotasDelta()).foreach { clientQuotasDelta =>
- clientQuotaMetadataManager.update(clientQuotasDelta)
- }
- } catch {
- case t: Throwable => metadataPublishingFaultHandler.handleFault("Error
updating client " +
- s"quotas in $deltaName", t)
- }
+ dynamicClientQuotaPublisher.onMetadataUpdate(delta, newImage)
- // Apply changes to SCRAM credentials.
- Option(delta.scramDelta()).foreach { scramDelta =>
- scramDelta.changes().forEach {
- case (mechanism, userChanges) =>
- userChanges.forEach {
- case (userName, change) =>
- if (change.isPresent) {
- credentialProvider.updateCredential(mechanism, userName,
change.get().toCredential(mechanism))
- } else {
- credentialProvider.removeCredentials(mechanism, userName)
- }
- }
- }
- }
+ // APply SCRAM delta.
Review Comment:
nit: `s/AP/Ap/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
